From: Colin Walters <walters@verbum.org>
Date: Fri, 23 Oct 2009 17:15:13 +0000 (-0400)
Subject: [ShellApp] Ignore removal of windows we're not interested in
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~10711
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=d9ff1f2ec16b7e10276c86d59f08cdf90820ee99;p=gnome-shell.git

[ShellApp] Ignore removal of windows we're not interested in

Previously shell_app_remove_window assumed that it was being
passed a window in its list; rather than having callers check
whether a window is interesting and only if so removing it
from the app, just ignore removal of windows we aren't interested
in, like how we ignore addition of windows we already have.

https://bugzilla.gnome.org/show_bug.cgi?id=598502
---

diff --git a/src/shell-app.c b/src/shell-app.c
index 3ae3f5c09..a0c56e4f9 100644
--- a/src/shell-app.c
+++ b/src/shell-app.c
@@ -324,6 +324,9 @@ void
 _shell_app_remove_window (ShellApp   *app,
                           MetaWindow *window)
 {
+  if (!g_slist_find (app->windows, window))
+    return;
+
   g_signal_handlers_disconnect_by_func (window, G_CALLBACK(shell_app_on_unmanaged), app);
   g_signal_handlers_disconnect_by_func (window, G_CALLBACK(shell_app_on_user_time_changed), app);
   g_object_unref (window);